mustafasrepo commented on code in PR #4777:
URL: https://github.com/apache/arrow-datafusion/pull/4777#discussion_r1061197203
##########
datafusion/physical-expr/src/window/window_expr.rs:
##########
@@ -132,3 +151,129 @@ pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr])
-> Vec<PhysicalSortExpr
})
.collect()
}
+
+pub enum WindowFn {
+ Builtin(Box<dyn PartitionEvaluator>),
+ Aggregate(Box<dyn Accumulator>),
+}
+
+impl fmt::Debug for WindowFn {
+ fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+ match self {
+ WindowFn::Builtin(builtin, ..) => {
+ write!(f, "partition evaluator: {:?}", builtin)
Review Comment:
Actually `#[derive(Debug)]` works. Thanks for pointing it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
