tustvold commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1061665815
##########
object_store/src/azure/mod.rs:
##########
@@ -832,4 +1051,61 @@ mod tests {
builder.parse_url(case).unwrap_err();
}
}
+
+ #[test]
+ fn azure_test_config_from_map() {
+ let azure_client_id = "object_store:fake_access_key_id".to_string();
Review Comment:
FWIW I think you could drop the to_string() and clone() from this test and
it should work
##########
object_store/src/azure/mod.rs:
##########
@@ -673,13 +872,33 @@ fn url_from_env(env_name: &str, default_url: &str) ->
Result<Url> {
Ok(url)
}
+fn split_sas(sas: &str) -> Result<Vec<(String, String)>, Error> {
Review Comment:
Do we have any tests of this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
