winding-lines commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1061456005
##########
object_store/src/aws/mod.rs:
##########
@@ -1125,6 +1149,31 @@ mod tests {
assert_eq!(builder.token.unwrap(), aws_session_token);
}
+ #[test]
+ fn s3_test_config_from_typed_map() {
+ let aws_access_key_id = "object_store:fake_access_key_id".to_string();
+ let aws_secret_access_key = "object_store:fake_secret_key".to_string();
+ let aws_default_region =
"object_store:fake_default_region".to_string();
+ let aws_endpoint = "object_store:fake_endpoint".to_string();
+ let aws_session_token = "object_store:fake_session_token".to_string();
+ let options = HashMap::from([
+ (AmazonS3ConfigKey::AccessKeyId, aws_access_key_id.clone()),
Review Comment:
This is very ergonomic, many thanks 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
