winding-lines commented on code in PR #3436:
URL: https://github.com/apache/arrow-rs/pull/3436#discussion_r1061473273
##########
object_store/src/aws/mod.rs:
##########
@@ -379,6 +383,170 @@ pub struct AmazonS3Builder {
client_options: ClientOptions,
}
+/// Configuration keys for [`AmazonS3Builder`]
+#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy)]
Review Comment:
@roeap this is very close, I think the last issue from my side is to derive
`serde::Serialize` and `Deserialize` for the `*ConfigKey` enums.
Pretty please 🤗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
