ozankabak commented on code in PR #4852:
URL: https://github.com/apache/arrow-datafusion/pull/4852#discussion_r1064194338
##########
datafusion/physical-expr/src/aggregate/correlation.rs:
##########
@@ -145,14 +149,34 @@ impl Accumulator for CorrelationAccumulator {
}
fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
- self.covar.update_batch(values)?;
+ let values = if values[0].null_count() != 0 || values[1].null_count()
!= 0 {
Review Comment:
Yes, for that we will need to in-line the logic in children accumulator to
here. No need to do that in this PR; we can do it in a subsequent PR. However I
suggest leaving a `TODO` in the code to remind us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
