korowa commented on code in PR #4852:
URL: https://github.com/apache/arrow-datafusion/pull/4852#discussion_r1064195074
##########
datafusion/physical-expr/src/aggregate/correlation.rs:
##########
@@ -145,14 +149,34 @@ impl Accumulator for CorrelationAccumulator {
}
fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
- self.covar.update_batch(values)?;
+ let values = if values[0].null_count() != 0 || values[1].null_count()
!= 0 {
Review Comment:
By inlinig you mean not using accumulators themselves, and instead storing
all required states in Covariance, updating them with Covariance inputs (just
as an example)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
