korowa commented on code in PR #4852:
URL: https://github.com/apache/arrow-datafusion/pull/4852#discussion_r1064195339
##########
datafusion/physical-expr/src/aggregate/correlation.rs:
##########
@@ -145,14 +149,34 @@ impl Accumulator for CorrelationAccumulator {
}
fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
- self.covar.update_batch(values)?;
+ let values = if values[0].null_count() != 0 || values[1].null_count()
!= 0 {
Review Comment:
Now it seems to me that splitting up input filtering and calculation logic
could help to solve these double-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
