[GitHub] [arrow-rs] viirya commented on pull request #3510: Make consistent behavior on zeros equality on floating point types

[GitBox]

viirya commented on PR #3510:
URL: https://github.com/apache/arrow-rs/pull/3510#issuecomment-1379590285

   > Not the ordering we use currently, they're ordered based on their 
constituent bits, NaNs with different byte representations will not compare 
equal
   
   We have NaN equality test to verify that they are equal. I also did a quick 
verification in rust playground:
   
   ```rust
   fn main() {
       let a = f32::NAN;
       let b = f32::NAN;
       
       println!("a == b: {}", a.to_bits() == b.to_bits());
   }
   ```
   
   Output:
   ```
   a == b: true
   ```
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org