viirya commented on code in PR #3510:
URL: https://github.com/apache/arrow-rs/pull/3510#discussion_r1067767546
##########
arrow-array/src/arithmetic.rs:
##########
@@ -363,15 +363,25 @@ macro_rules! native_type_float_op {
#[inline]
fn compare(self, rhs: Self) -> Ordering {
- <$t>::total_cmp(&self, &rhs)
+ if self.abs() == $zero && rhs.abs() == $zero {
+ // `total_cmp` treats positive zero and negative zero as
different.
+ // But for computation system, it usually treats them as
equal.
+ Ordering::Equal
+ } else {
+ <$t>::total_cmp(&self, &rhs)
+ }
Review Comment:
I removed these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
