viirya commented on code in PR #3510:
URL: https://github.com/apache/arrow-rs/pull/3510#discussion_r1067768647
##########
arrow-ord/src/ord.rs:
##########
@@ -380,8 +358,8 @@ pub mod tests {
let cmp = build_compare(&array, &array).unwrap();
- assert_eq!(Ordering::Equal, (cmp)(0, 1));
- assert_eq!(Ordering::Equal, (cmp)(1, 0));
+ assert_eq!(Ordering::Less, (cmp)(0, 1));
+ assert_eq!(Ordering::Greater, (cmp)(1, 0));
Review Comment:
`build_compare`'s behavior on zeros comparison is inconsistent with
comparison kernels. Changed it to consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
