westonpace commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1070127381
########## .github/pull_request_template.md: ########## @@ -57,5 +57,11 @@ If there are user-facing changes then we may require documentation to be updated --> <!-- -If there are any breaking changes to public APIs, please add the `breaking-change` label. ---> \ No newline at end of file +If there are any breaking changes to public APIs, please uncomment the following line: +--> +<!-- **This PR includes breaking changes to public APIs.** --> + +<!-- +If the changes fix either a security vulnerability or a bug that caused incorrect or invalid data to be produced. This is intended to mark changes that may affect users without their knowledge. For this reason, fixing bugs that cause errors or crashes don't count, since those are usually obvious. +--> Review Comment: This is a little confusing to me. If we were previously giving the wrong answer, and we fixed something to give a new answer, would I mark it as both breaking change and critical fix? Also, hopefully most security fixes would go unnoticed by a user. I wouldn't expect them (by default) to change the output or the API. Also, do we want to carve out an exception for experimental APIs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
