westonpace commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1070168025
########## .github/pull_request_template.md: ########## @@ -57,5 +57,11 @@ If there are user-facing changes then we may require documentation to be updated --> <!-- -If there are any breaking changes to public APIs, please add the `breaking-change` label. ---> \ No newline at end of file +If there are any breaking changes to public APIs, please uncomment the following line: +--> +<!-- **This PR includes breaking changes to public APIs.** --> + +<!-- +If the changes fix either a security vulnerability or a bug that caused incorrect or invalid data to be produced. This is intended to mark changes that may affect users without their knowledge. For this reason, fixing bugs that cause errors or crashes don't count, since those are usually obvious. +--> Review Comment: > Another way to put it is "Breaking Changes" are the reasons you might not want to upgrade until you have time to adapt your code, while "Critical Changes" highlight the risk of not upgrading. This description is very helpful, let's include some of it. > If we wanted, we could consider a separate tag for Experimental API Change. No, I think your rationale is ok. Even in our experimental APIs we usually avoid breaking changes if we can so it isn't like they occur all that often. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
