jorisvandenbossche commented on code in PR #33660: URL: https://github.com/apache/arrow/pull/33660#discussion_r1070923841
########## .github/pull_request_template.md: ########## @@ -57,5 +57,10 @@ If there are user-facing changes then we may require documentation to be updated --> <!-- -If there are any breaking changes to public APIs, please add the `breaking-change` label. ---> \ No newline at end of file +If there are any breaking changes to public APIs, please check the box below: +--> +* [ ] This PR includes breaking changes to public APIs. +<!-- +Check the box below if the changes fix either a security vulnerability or a bug that caused incorrect or invalid data to be produced. We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors or crashes don't count, since those are usually obvious. +--> +* [ ] This PR contains a "Critical Fix". Review Comment: Minor argument against using checkboxes for this: this adds a "todo" list to each PR, and then the GitHub UI will show this for example as "1 of 2 tasks" done in the pull request listing (ideally github would also allow you use a "form" and not just a template, so this could be an actual checkbox that would add the label) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
