DDtKey commented on code in PR #4942:
URL: https://github.com/apache/arrow-datafusion/pull/4942#discussion_r1072041483
##########
datafusion/common/src/error.rs:
##########
@@ -160,11 +158,11 @@ impl Display for SchemaError {
} else {
write!(f, "'{}'", field.name)?;
}
- if let Some(fields) = valid_fields {
+ if !valid_fields.is_empty() {
Review Comment:
I'm wondering if we should add some additional text in case if it's empty?
Like `No data source passed`, `No valid fields` and etc.
If we should add it, pls add your suggestion of error message 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
