DDtKey commented on code in PR #4942:
URL: https://github.com/apache/arrow-datafusion/pull/4942#discussion_r1072042421
##########
datafusion/common/src/error.rs:
##########
@@ -125,7 +125,7 @@ pub enum SchemaError {
/// No field with this name
FieldNotFound {
field: Column,
- valid_fields: Option<Vec<Column>>,
+ valid_fields: Vec<Column>,
Review Comment:
I've not found any reason to have `Option` here, `Vec` could be empty and it
would be zero-size. Moreover, there is no usages of `None` at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
