DDtKey commented on code in PR #4942:
URL: https://github.com/apache/arrow-datafusion/pull/4942#discussion_r1072473429
##########
datafusion/common/src/error.rs:
##########
@@ -160,11 +158,11 @@ impl Display for SchemaError {
} else {
write!(f, "'{}'", field.name)?;
}
- if let Some(fields) = valid_fields {
+ if !valid_fields.is_empty() {
Review Comment:
Currently (in this PR) it will just return `Schema error: No field named
'name'` (i.e `valid fields are ` won't be printed as before)
Let me know if I should add additional text for this case.
##########
datafusion/common/src/error.rs:
##########
@@ -160,11 +158,11 @@ impl Display for SchemaError {
} else {
write!(f, "'{}'", field.name)?;
}
- if let Some(fields) = valid_fields {
+ if !valid_fields.is_empty() {
Review Comment:
Currently (in this PR) it will just return `Schema error: No field named
'name'` (i.e `valid fields are ` won't be in the message as before)
Let me know if I should add additional text for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
