lidavidm commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1073580583
##########
cpp/src/arrow/type_traits.h:
##########
@@ -1177,6 +1197,7 @@ constexpr bool is_nested(Type::type type_id) {
case Type::STRUCT:
case Type::SPARSE_UNION:
case Type::DENSE_UNION:
+ case Type::RUN_END_ENCODED:
Review Comment:
From a quick glance, I think this is mostly used as 'physically nested' in
the codebase, so this is OK. I don't think we have the right abstractions to
differentiate between physical/logical and deal with encodings, e.g. the way we
handle dictionaries is often to just decode them, and kernel implementations
are very much often lost in the weeds of encoding details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
