pitrou commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1073852207
##########
cpp/src/arrow/array/data.cc:
##########
@@ -195,6 +195,7 @@ int GetNumBuffers(const DataType& type) {
case Type::NA:
case Type::STRUCT:
case Type::FIXED_SIZE_LIST:
+ case Type::RUN_END_ENCODED:
return 1;
Review Comment:
Well, note that this function does not reflect the number of buffers in the
IPC layout, but the number of buffers _in Arrow C++_.
We have special code to work around it in the IPC layer:
https://github.com/apache/arrow/blob/359f28ba9d62a5e8456d92dfbe5b16b790019edd/cpp/src/arrow/ipc/reader.cc#L330-L335
https://github.com/apache/arrow/blob/359f28ba9d62a5e8456d92dfbe5b16b790019edd/cpp/src/arrow/ipc/writer.cc#L157-L169
So we could choose to also have a dummy null bitmap entry (in Arrow C++) for
run-end encoded arrays, or not.
@lidavidm @westonpace What are your opinions on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
