lidavidm commented on code in PR #381:
URL: https://github.com/apache/arrow-adbc/pull/381#discussion_r1085733078
##########
docs/source/driver/go/flight_sql.rst:
##########
@@ -80,63 +84,56 @@ API specification 1.0.0, as well as some additional, custom
options.
Authentication
--------------
-The driver does no authentication by default.
+The driver does no authentication by default. The driver implements a
+few optional authentication schemes:
-The driver implements one optional authentication scheme that mimics
-the Arrow Flight SQL JDBC driver. This can be enabled by setting the
-option ``arrow.flight.sql.authorization_header`` on the
-:cpp:class:`AdbcDatabase`. The client provides credentials by setting
-the option value to the value of the ``authorization`` header sent
-from client to server. The server then responds with an
-``authorization`` header on the first request. The value of this
-header will then be sent back as the ``authorization`` header on all
-future requests.
+- A user/password scheme: TODO
Review Comment:
(in future PRs)
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -116,47 +122,81 @@ type database struct {
}
func (d *database) SetOptions(cnOptions map[string]string) error {
- if d.uri.Scheme == "grpc+tls" {
- d.creds = credentials.NewTLS(&tls.Config{})
- } else {
- d.creds = insecure.NewCredentials()
- }
+ var tlsConfig tls.Config
- if val, ok := cnOptions[OptionSSLSkipVerify]; ok && val ==
adbc.OptionValueEnabled {
- if d.uri.Scheme != "grpc+tls" {
+ mtlsCert := cnOptions[OptionMTLSCertChain]
+ mtlsKey := cnOptions[OptionMTLSPrivateKey]
Review Comment:
I don't believe so, mTLS requires a valid cert and corresponding private key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
