zeroshade commented on code in PR #381:
URL: https://github.com/apache/arrow-adbc/pull/381#discussion_r1085733227
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -611,15 +655,23 @@ func (c *cnxn) Close() error {
//
// A partition can be retrieved by using ExecutePartitions on a statement.
func (c *cnxn) ReadPartition(ctx context.Context, serializedPartition []byte)
(rdr array.RecordReader, err error) {
- var endpoint flight.FlightEndpoint
- if err := proto.Unmarshal(serializedPartition, &endpoint); err != nil {
+ var info flight.FlightInfo
+ if err := proto.Unmarshal(serializedPartition, &info); err != nil {
return nil, adbc.Error{
Msg: err.Error(),
Code: adbc.StatusInvalidArgument,
}
}
- rdr, err = doGet(ctx, c.cl, &endpoint, c.clientCache)
+ // The driver only ever returns one endpoint.
Review Comment:
this isn't a guarantee though? The number of endpoints would be determined
by the server it's communicating with, wouldn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
