zeroshade commented on code in PR #381:
URL: https://github.com/apache/arrow-adbc/pull/381#discussion_r1085735754
##########
go/adbc/driver/flightsql/flightsql_statement.go:
##########
@@ -279,7 +279,9 @@ func (s *statement) ExecutePartitions(ctx context.Context)
(*arrow.Schema, adbc.
out.NumPartitions = uint64(len(info.Endpoint))
out.PartitionIDs = make([][]byte, out.NumPartitions)
for i, e := range info.Endpoint {
- data, err := proto.Marshal(e)
+ partition := proto.Clone(info).(*flight.FlightInfo)
+ partition.Endpoint = []*flight.FlightEndpoint{e}
+ data, err := proto.Marshal(partition)
Review Comment:
why do this? What if a server provides multiple optional endpoints for a
given partition so a consumer can use a geographically closer one? shouldn't we
let that be propagated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
