pitrou commented on code in PR #33776:
URL: https://github.com/apache/arrow/pull/33776#discussion_r1092023670
##########
cpp/src/parquet/bloom_filter_test.cc:
##########
@@ -242,6 +236,77 @@ TEST(OptimalValueTest, TestBloomFilter) {
UINT32_C(1073741824));
}
+int64_t HASHES_OF_LOOPING_BYTES_WITH_SEED_0[32] = {
Review Comment:
I'm not sure this test is actually useful. At least it's quite long for just
checking that we wrap xxhash correctly.
It would be enough to test a well known test vector, e.g.:
```python
>>> xxhash.xxh64_digest(b"hello world", seed=0)
b'E\xabg4\xb2\x1eih'
>>> xxhash.xxh64_digest(b"hello world", seed=42)
b'i\xc2\xb6\x8f\x9d\x93R\xa1'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
