pitrou commented on code in PR #33776:
URL: https://github.com/apache/arrow/pull/33776#discussion_r1092034532
##########
cpp/src/parquet/xxhasher.h:
##########
@@ -29,12 +25,10 @@
namespace parquet {
-/// Source:
-/// https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp
-/// (Modified to adapt to coding conventions and to inherit the Hasher
abstract class)
-class PARQUET_EXPORT MurmurHash3 : public Hasher {
+class PARQUET_EXPORT XxHasher : public Hasher {
public:
- MurmurHash3() : seed_(DEFAULT_SEED) {}
+ XxHasher() : seed_(kDefaultSeed) {}
Review Comment:
Just for the record, is the seed parameter actually useful? The Parquet spec
mandates seed value 0. Hardcoding the seed might make hashing slightly faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
