pitrou commented on code in PR #33776:
URL: https://github.com/apache/arrow/pull/33776#discussion_r1092067787
##########
cpp/src/parquet/xxhasher.h:
##########
@@ -29,12 +25,10 @@
namespace parquet {
-/// Source:
-/// https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp
-/// (Modified to adapt to coding conventions and to inherit the Hasher
abstract class)
-class PARQUET_EXPORT MurmurHash3 : public Hasher {
+class PARQUET_EXPORT XxHasher : public Hasher {
public:
- MurmurHash3() : seed_(DEFAULT_SEED) {}
+ XxHasher() : seed_(kDefaultSeed) {}
Review Comment:
> https://godbolt.org/z/bjz5WGx83 Seems maybe it will.
I don't think this example is proving anything as 1) everything is
implemented in the `.h` (thus trivially inlinable) 2) the result value doesn't
even depend on the seed.
> Still I think `Hasher` is not ParquetHasher, the name of it is too
No, but it's in the `src/parquet` directory, which is a good hint :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
