andygrove commented on code in PR #658:
URL: https://github.com/apache/arrow-ballista/pull/658#discussion_r1102848846
##########
ballista/scheduler/src/cluster/storage/sled.rs:
##########
@@ -305,33 +305,33 @@ mod tests {
Ok(())
}
- #[tokio::test]
- async fn multiple_operation() -> Result<(), Box<dyn std::error::Error>> {
- let client = create_instance()?;
- let key = "key".to_string();
- let value = "value".as_bytes().to_vec();
- let locks = client
- .acquire_locks(vec![(Keyspace::ActiveJobs, ""), (Keyspace::Slots,
"")])
- .await?;
-
- let _r: ballista_core::error::Result<()> = with_locks(locks, async {
- let txn_ops = vec![
- (Operation::Put(value.clone()), Keyspace::Slots, key.clone()),
- (
- Operation::Put(value.clone()),
- Keyspace::ActiveJobs,
- key.clone(),
- ),
- ];
- client.apply_txn(txn_ops).await?;
- Ok(())
- })
- .await;
-
- assert_eq!(client.get(Keyspace::Slots, key.as_str()).await?, value);
- assert_eq!(client.get(Keyspace::ActiveJobs, key.as_str()).await?,
value);
- Ok(())
- }
+ // #[tokio::test]
Review Comment:
Is this test intentionally commented out? Should we add a link to an issue
explaining why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
