andygrove commented on code in PR #658:
URL: https://github.com/apache/arrow-ballista/pull/658#discussion_r1102852483
##########
ballista/scheduler/src/bin/main.rs:
##########
@@ -117,10 +100,13 @@ async fn main() -> Result<()> {
.init();
}
- let addr = format!("{bind_host}:{port}");
+ let addr = format!("{}:{}", opt.bind_host, opt.bind_port);
let addr = addr.parse()?;
let config = SchedulerConfig {
+ namespace: opt.namespace,
+ external_host: opt.external_host,
Review Comment:
It looks like `bind_host` is not currently used in the scheduler, but it is
in the executor, so this seems like an oversight.
cc @avantgardnerio who may have opinions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
