thinkharderdev commented on code in PR #658:
URL: https://github.com/apache/arrow-ballista/pull/658#discussion_r1102894941
##########
ballista/scheduler/src/bin/main.rs:
##########
@@ -117,10 +100,13 @@ async fn main() -> Result<()> {
.init();
}
- let addr = format!("{bind_host}:{port}");
+ let addr = format!("{}:{}", opt.bind_host, opt.bind_port);
let addr = addr.parse()?;
let config = SchedulerConfig {
+ namespace: opt.namespace,
+ external_host: opt.external_host,
Review Comment:
Sorry, this is slightly confusing :). It is still used to build the bind
address for the server
```
let addr = format!("{}:{}", opt.bind_host, opt.bind_port);
let addr = addr.parse()?;
```
The reason `external_host` was added to `SchedulerConfig` is so that we can
pass it in to `start_server` and build the `BallistaCluster` there only from
the `SchedulerConfig`. In order to do that I had to pass a few more things from
the `Config` struct generated by `configure_me` which isn't available in the
lib code.
So really the only point is to further minimize what we do in `main.rs` to
just setting up logging and validating CLI arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
