icexelloss commented on code in PR #34156:
URL: https://github.com/apache/arrow/pull/34156#discussion_r1105916065
##########
python/pyarrow/includes/libarrow_substrait.pxd:
##########
@@ -34,10 +50,26 @@ cdef extern from "arrow/engine/substrait/options.h"
namespace "arrow::engine" no
BEST_EFFORT \
"arrow::engine::ConversionStrictness::BEST_EFFORT"
+ cdef cppclass CExtensionDetails \
+ "arrow::ending::ExtensionDetails"
Review Comment:
This should be "engine"?
Does it not error out if this is wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
