rtpsw commented on PR #34156: URL: https://github.com/apache/arrow/pull/34156#issuecomment-1430211113
> @rtpsw This is tested internally and works? There are no new tests, but the change in `ConversionOptions` is covered by existing tests. The difficulty with a distinguishing test for this change, i.e., a test that fails pre-PR code but passes post-PR, is that it would need to somehow tinker with the order of initialization (see #34150) - there is no precedent of doing this in Arrow that I know of. > (I am surprised that nothing breaks because of the engine typo) Yes, that surprised me too. I'll try to figure out why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
