rtpsw commented on PR #34156: URL: https://github.com/apache/arrow/pull/34156#issuecomment-1430106854
> @rtpsw IIUC, there are two changes in this PR: (1) Fix ConversionOptions initialization (2) Add python bindings for ExtensionDetails, set_default_extension_provider, ExtensionProvider, ExtensionSet, etc > > If that is correct, I think we don't necessarily need to mix the two - the first is a bug fix and second is additional functionality. > > I am comfortable with approving (1) and but I am not sure about (2) so probably need Weston's input (I believe VD folks are in a conference so there might be delay) The reason for (2) is because API signatures of `ConversionOptions` bring in other symbols. There might be some symbols we could reduce, but not all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
