pitrou commented on a change in pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#discussion_r524192977
##########
File path: cpp/src/parquet/encoding.cc
##########
@@ -127,6 +129,21 @@ class PlainEncoder : public EncoderImpl, virtual public
TypedEncoder<DType> {
}
protected:
+ template <typename ArrayType>
Review comment:
`Put(const ::arrow::Array&)` was hardwired for narrow binary arrays, we
need to handle both narrow and large arrays, hence this small refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
