pitrou commented on a change in pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#discussion_r524194140
##########
File path: cpp/src/parquet/encoding.cc
##########
@@ -592,6 +597,29 @@ class DictEncoderImpl : public EncoderImpl, virtual public
DictEncoder<DType> {
/// Indices that have not yet be written out by WriteIndices().
ArrowPoolVector<int32_t> buffered_indices_;
+ template <typename ArrayType>
+ void PutBinaryArray(const ArrayType& array) {
+ ::arrow::VisitArrayDataInline<typename ArrayType::TypeClass>(
+ *array.data(),
+ [&](::arrow::util::string_view view) {
+ // XXX check length
Review comment:
Will do :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
