pitrou commented on a change in pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#discussion_r524195648
##########
File path: cpp/src/parquet/statistics.cc
##########
@@ -691,9 +634,60 @@ void TypedStatisticsImpl<ByteArrayType>::PlainDecode(const
std::string& src,
dst->ptr = reinterpret_cast<const uint8_t*>(src.c_str());
}
+} // namespace
+
// ----------------------------------------------------------------------
// Public factory functions
+std::shared_ptr<Comparator> Comparator::Make(Type::type physical_type,
+ SortOrder::type sort_order,
+ int type_length) {
+ if (SortOrder::SIGNED == sort_order) {
Review comment:
Yes, so as to put internal implementation details in the anonymous
namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
