icexelloss commented on code in PR #34279: URL: https://github.com/apache/arrow/pull/34279#discussion_r1114884741
########## python/pyarrow/_substrait.pyx: ########## @@ -27,7 +27,7 @@ from pyarrow.includes.libarrow cimport * from pyarrow.includes.libarrow_substrait cimport * -cdef CDeclaration _create_named_table_provider(dict named_args, const std_vector[c_string]& names): +cdef CDeclaration _create_named_table_provider(dict named_args, const std_vector[c_string]& names, const CSchema& schema): Review Comment: Actually - hold off - I think I didn't handle ownership correctly - should be probably doing a copy instead of move here. Let me see if I can fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
