icexelloss commented on code in PR #34279: URL: https://github.com/apache/arrow/pull/34279#discussion_r1114673040
########## python/pyarrow/_substrait.pyx: ########## @@ -27,7 +27,7 @@ from pyarrow.includes.libarrow cimport * from pyarrow.includes.libarrow_substrait cimport * -cdef CDeclaration _create_named_table_provider(dict named_args, const std_vector[c_string]& names): +cdef CDeclaration _create_named_table_provider(dict named_args, const std_vector[c_string]& names, const CSchema& schema): Review Comment: Yeah the python side support for this is left out but we only use named table provider via the C++ API. I didn't do the python side because (1) we don't use it and (2) I am not very familiar with the python C extension. (Took me a while to figure the current C extension changes just to get it working). ########## python/pyarrow/_substrait.pyx: ########## @@ -27,7 +27,7 @@ from pyarrow.includes.libarrow cimport * from pyarrow.includes.libarrow_substrait cimport * -cdef CDeclaration _create_named_table_provider(dict named_args, const std_vector[c_string]& names): +cdef CDeclaration _create_named_table_provider(dict named_args, const std_vector[c_string]& names, const CSchema& schema): Review Comment: Yeah the python side support for this is left out. I didn't do the python side because (1) we don't use it and (2) I am not very familiar with the python C extension. (Took me a while to figure the current C extension changes just to get it working). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
