westonpace commented on code in PR #34279:
URL: https://github.com/apache/arrow/pull/34279#discussion_r1114657183
##########
python/pyarrow/_substrait.pyx:
##########
@@ -27,7 +27,7 @@ from pyarrow.includes.libarrow cimport *
from pyarrow.includes.libarrow_substrait cimport *
-cdef CDeclaration _create_named_table_provider(dict named_args, const
std_vector[c_string]& names):
+cdef CDeclaration _create_named_table_provider(dict named_args, const
std_vector[c_string]& names, const CSchema& schema):
Review Comment:
I suppose we would eventually want to pass this schema on to the python
function correct?
Something like:
```
c_schema_sp = shared_ptr[CSchema](schema)
py_schema = wrap_schema(c_schema_sp)
py_table = named_args["provider"](py_names, py_schema)
```
Do you not need this for your use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
