ozankabak commented on code in PR #5322: URL: https://github.com/apache/arrow-datafusion/pull/5322#discussion_r1114957696
########## datafusion/physical-expr/src/intervals/mod.rs: ########## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: We evaluated the existing approaches but couldn't leverage them for this as they were not general enough (and we didn't see a way to generalize them in their existing structure). @metesynnada can provide more details about this. > Would you be willing to help unify the implementations (I don't really have a preference as to which, only that we don't have three) Yes! This is actually on our roadmap, and we are designing the interval arithmetic library so that it is general purpose and appropriate for other use cases too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
