metesynnada commented on code in PR #5322: URL: https://github.com/apache/arrow-datafusion/pull/5322#discussion_r1115296675
########## datafusion/physical-expr/src/intervals/test_utils.rs: ########## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +//http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Test utilities for the interval arithmetic library + +use std::sync::Arc; + +use crate::expressions::{BinaryExpr, Literal}; +use crate::PhysicalExpr; +use datafusion_common::ScalarValue; +use datafusion_expr::Operator; + +#[allow(clippy::too_many_arguments)] +/// This test function generates a conjunctive statement with two numeric +/// terms with the following form: +/// left_col (op_1) a > right_col (op_2) b AND left_col (op_3) c < right_col (op_4) d +pub fn gen_conjunctive_numeric_expr( + left_col: Arc<dyn PhysicalExpr>, + right_col: Arc<dyn PhysicalExpr>, + op_1: Operator, + op_2: Operator, + op_3: Operator, + op_4: Operator, + a: i32, + b: i32, + c: i32, + d: i32, +) -> Arc<dyn PhysicalExpr> { + let left_and_1 = Arc::new(BinaryExpr::new( + left_col.clone(), + op_1, + Arc::new(Literal::new(ScalarValue::Int32(Some(a)))), Review Comment: Thanks, I will leverage these methods in other parts of the codes as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
