vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r525984998
##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -570,27 +570,26 @@ where
));
}
- let num_bytes = bit_util::ceil(left_len, 8);
+ let num_bytes = utils::ceil(left_len, 8);
let not_both_null_bit_buffer =
match combine_option_bitmap(left.data_ref(), right.data_ref(),
left_len)? {
Some(buff) => buff,
None => new_all_set_buffer(num_bytes),
};
- let not_both_null_bitmap = not_both_null_bit_buffer.data();
+ let _not_both_null_bitmap = not_both_null_bit_buffer.data();
Review comment:
Things that I forgot along the lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
