vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526161079
##########
File path: rust/arrow/src/compute/kernels/aggregate.rs
##########
@@ -219,24 +223,27 @@ where
let data_chunks = data.chunks_exact(64);
let remainder = data_chunks.remainder();
- let bit_chunks = buffer.bit_chunks(array.offset(), array.len());
+ let bit_slice = buffer.bit_slice().view(array.offset(),
array.len());
+ let bit_chunks = bit_slice.chunks::<u64>();
let remainder_bits = bit_chunks.remainder_bits();
- data_chunks.zip(bit_chunks).for_each(|(chunk, mut mask)| {
- // split chunks further into slices corresponding to the
vector length
- // the compiler is able to unroll this inner loop and remove
bounds checks
- // since the outer chunk size (64) is always a multiple of the
number of lanes
- chunk.chunks_exact(T::lanes()).for_each(|chunk| {
- let zero = T::init(T::default_value());
- let vecmask = T::mask_from_u64(mask);
- let chunk = T::load(&chunk);
- let blended = T::mask_select(vecmask, chunk, zero);
-
- vector_sum = vector_sum + blended;
-
- mask = mask >> T::lanes();
+ data_chunks
+ .zip(bit_chunks.interpret())
Review comment:
Addressed.
##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -570,27 +570,26 @@ where
));
}
- let num_bytes = bit_util::ceil(left_len, 8);
+ let num_bytes = utils::ceil(left_len, 8);
let not_both_null_bit_buffer =
match combine_option_bitmap(left.data_ref(), right.data_ref(),
left_len)? {
Some(buff) => buff,
None => new_all_set_buffer(num_bytes),
};
- let not_both_null_bitmap = not_both_null_bit_buffer.data();
+ let _not_both_null_bitmap = not_both_null_bit_buffer.data();
Review comment:
Addressed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
