helmus commented on code in PR #3766:
URL: https://github.com/apache/arrow-rs/pull/3766#discussion_r1117997685
##########
object_store/src/aws/credential.rs:
##########
@@ -553,18 +553,7 @@ mod profile {
store: "S3",
source: Box::new(source),
})?;
-
- let t_now = SystemTime::now();
- let expiry = match c.expiry().and_then(|e|
e.duration_since(t_now).ok()) {
Review Comment:
The expiry() method returns the
[expires_after](https://github.com/awslabs/smithy-rs/blob/76ee00eb1737964ce240ae817f573980920f0607/aws/rust-runtime/aws-credential-types/src/credentials_impl.rs#L36)
field, which is not loaded from the aws profile in the credentials file, but
instead is made optionally available to the caller as a caching ttl field. (
[reference for that
here](https://github.com/awslabs/smithy-rs/blob/76ee00eb1737964ce240ae817f573980920f0607/aws/rust-runtime/aws-credential-types/src/credentials_impl.rs#L29-L36)
, there is an expiry_mut() method as well, allowing the caller to modify the
expiration. ).
This value will always be `None`, resulting in `Invalid expiry` Error every
time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
