[GitHub] [arrow-rs] helmus commented on a diff in pull request #3766: object-store: fix handling of AWS profile credentials without expiry

Mon, 27 Feb 2023 07:54:26 -0800 


helmus commented on code in PR #3766:
URL: https://github.com/apache/arrow-rs/pull/3766#discussion_r1118939586


##########
object_store/src/aws/credential.rs:
##########
@@ -553,18 +553,7 @@ mod profile {
                             store: "S3",
                             source: Box::new(source),
                         })?;
-
-                let t_now = SystemTime::now();
-                let expiry = match c.expiry().and_then(|e| 
e.duration_since(t_now).ok()) {

Review Comment:
   expiry of `None` does mean the credentials do not expire. This PR at least 
ensures the credentials are cached for at least 1 hour if they never expire.
   
   <img width="776" alt="image" 
src="https://user-images.githubusercontent.com/1042463/221612600-73091aed-0723-4ee3-8399-a84172fe1332.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to