tustvold commented on code in PR #3766:
URL: https://github.com/apache/arrow-rs/pull/3766#discussion_r1118705990
##########
object_store/src/aws/credential.rs:
##########
@@ -553,18 +553,7 @@ mod profile {
store: "S3",
source: Box::new(source),
})?;
-
- let t_now = SystemTime::now();
- let expiry = match c.expiry().and_then(|e|
e.duration_since(t_now).ok()) {
Review Comment:
I'm not sure about this, there are definitely situations where the
credentials will expire e.g. SAML.
Perhaps we could instead interpret a missing expiry as infinite expiration
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
