srebhan commented on PR #34331: URL: https://github.com/apache/arrow/pull/34331#issuecomment-1447142330
@jacobmarble it's not only about wrapping the registration, it's about the fundamental addition of (IMO unnecessary) complexity. The ADBC `database/sql` driver is a wrapper around `ADBC` as such it adds another indirection from the database, i.e. `Application -> database/sql -> ADBC -> FlightSQL -> Backend` vs. `Application -> database/sql -> FlightSQL -> Backend`. It's like writing a wrapper around ODBC... What is the benefit, given that `database/sql` is the defacto standard in go? The clear drawback for the user is to deal with ADBC. From the docs it's not yet clear to me which "ADBC drivers" I need. Are they bundled with the driver? If so, how to deal with growing dependencies and code when adding new drivers? What if CGO is not allowed in the application? I'm certainly willing to work on this PR, but it sounds like there is some resistance to the idea. Please let me know if there is a realistic chance of getting this merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
