mingmwang commented on code in PR #5322:
URL: https://github.com/apache/arrow-datafusion/pull/5322#discussion_r1119508328
##########
datafusion/core/src/physical_optimizer/pipeline_fixer.rs:
##########
@@ -49,16 +57,18 @@ impl PipelineFixer {
}
}
type PipelineFixerSubrule =
- dyn Fn(&PipelineStatePropagator) ->
Option<Result<PipelineStatePropagator>>;
+ dyn Fn(PipelineStatePropagator) -> Option<Result<PipelineStatePropagator>>;
Review Comment:
Could you please add some comments for the type definition `dyn
Fn(PipelineStatePropagator) -> Option<Result<PipelineStatePropagator>>` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
