mingmwang commented on PR #5322: URL: https://github.com/apache/arrow-datafusion/pull/5322#issuecomment-1443017531
> I read the blog https://synnada.notion.site/synnada/General-purpose-Stream-Joins-via-Pruning-Symmetric-Hash-Joins-2fe26d3127a241e294a0217b1f18603a which was very helpful understanding this PR. Thank you so much for writing that. > > I made it about half way though this PR today and hope to complete my initial review tomorrow but wanted to leave the feedback I had so far. . > > I initially focused on the larger architectural structure and I found this code very well commented and tested ❤️ > > My biggest concern so far is the addition of a third way to do interval analysis. I really like the rigor and sophistication of the interval analysis in this PR but I worry about having so many. > > All in all really impressive work @metesynnada really nice tech blog!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
