mingmwang commented on code in PR #5322:
URL: https://github.com/apache/arrow-datafusion/pull/5322#discussion_r1116780755
##########
datafusion/core/src/physical_plan/joins/utils.rs:
##########
@@ -770,52 +794,49 @@ pub(crate) fn apply_join_filter_to_indices(
let mask = as_boolean_array(&filter_result)?;
let left_filtered = PrimitiveArray::<UInt64Type>::from(
- compute::filter(&left_indices, mask)?.data().clone(),
+ compute::filter(&build_indices, mask)?.data().clone(),
);
let right_filtered = PrimitiveArray::<UInt32Type>::from(
- compute::filter(&right_indices, mask)?.data().clone(),
+ compute::filter(&probe_indices, mask)?.data().clone(),
);
-
Ok((left_filtered, right_filtered))
}
/// Returns a new [RecordBatch] by combining the `left` and `right` according
to `indices`.
/// The resulting batch has [Schema] `schema`.
pub(crate) fn build_batch_from_indices(
schema: &Schema,
- left: &RecordBatch,
- right: &RecordBatch,
- left_indices: UInt64Array,
- right_indices: UInt32Array,
+ build_input_buffer: &RecordBatch,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
