Dandandan commented on code in PR #5408:
URL: https://github.com/apache/arrow-datafusion/pull/5408#discussion_r1119789555
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -41,7 +41,7 @@ pub struct DistinctCount {
/// The DataType for the final count
data_type: DataType,
/// The DataType used to hold the state for each input
- state_data_types: Vec<DataType>,
+ state_data_types: DataType,
/// The input arguments
exprs: Vec<Arc<dyn PhysicalExpr>>,
Review Comment:
I think we should also update `exprs: Vec<Arc<dyn PhysicalExpr>>` to `exprs:
Arc<dyn PhysicalExpr>` and `DistinctCount::new` to communicate that multiple
columns are no longer supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
