Dandandan commented on code in PR #5408:
URL: https://github.com/apache/arrow-datafusion/pull/5408#discussion_r1121728655
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -113,106 +102,61 @@ impl AggregateExpr for DistinctCount {
#[derive(Debug)]
struct DistinctCountAccumulator {
values: HashSet<DistinctScalarValues, RandomState>,
- state_data_types: Vec<DataType>,
+ state_data_types: DataType,
count_data_type: DataType,
Review Comment:
Can you remove this as well (it's basically unused by now)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
