Dandandan commented on code in PR #5408:
URL: https://github.com/apache/arrow-datafusion/pull/5408#discussion_r1121836671
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -30,36 +30,29 @@ use datafusion_common::ScalarValue;
use datafusion_common::{DataFusionError, Result};
use datafusion_expr::Accumulator;
-#[derive(Debug, PartialEq, Eq, Hash, Clone)]
-struct DistinctScalarValues(Vec<ScalarValue>);
+type DistinctScalarValues = ScalarValue;
/// Expression for a COUNT(DISTINCT) aggregation.
#[derive(Debug)]
pub struct DistinctCount {
/// Column name
name: String,
- /// The DataType for the final count
- data_type: DataType,
/// The DataType used to hold the state for each input
- state_data_types: Vec<DataType>,
+ state_data_types: DataType,
/// The input arguments
- exprs: Vec<Arc<dyn PhysicalExpr>>,
+ exprs: Arc<dyn PhysicalExpr>,
Review Comment:
```suggestion
expr: Arc<dyn PhysicalExpr>,
```
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -30,36 +30,29 @@ use datafusion_common::ScalarValue;
use datafusion_common::{DataFusionError, Result};
use datafusion_expr::Accumulator;
-#[derive(Debug, PartialEq, Eq, Hash, Clone)]
-struct DistinctScalarValues(Vec<ScalarValue>);
+type DistinctScalarValues = ScalarValue;
/// Expression for a COUNT(DISTINCT) aggregation.
#[derive(Debug)]
pub struct DistinctCount {
/// Column name
name: String,
- /// The DataType for the final count
- data_type: DataType,
/// The DataType used to hold the state for each input
- state_data_types: Vec<DataType>,
+ state_data_types: DataType,
/// The input arguments
- exprs: Vec<Arc<dyn PhysicalExpr>>,
+ exprs: Arc<dyn PhysicalExpr>,
}
impl DistinctCount {
/// Create a new COUNT(DISTINCT) aggregate function.
pub fn new(
- input_data_types: Vec<DataType>,
- exprs: Vec<Arc<dyn PhysicalExpr>>,
+ input_data_types: DataType,
+ exprs: Arc<dyn PhysicalExpr>,
Review Comment:
```suggestion
expr: Arc<dyn PhysicalExpr>,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
